Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NativeAOT] Enable smoke tests on macOS #76560

Merged
merged 1 commit into from
Dec 12, 2022
Merged

[NativeAOT] Enable smoke tests on macOS #76560

merged 1 commit into from
Dec 12, 2022

Conversation

filipnavara
Copy link
Member

No description provided.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Oct 3, 2022
@ghost
Copy link

ghost commented Oct 3, 2022

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: filipnavara
Assignees: -
Labels:

area-Infrastructure-coreclr
Milestone: -

@filipnavara filipnavara marked this pull request as ready for review October 4, 2022 06:05
@MichalStrehovsky
Copy link
Member 

runtime Successful in 2m — Build #20221003.56 succeeded

That's a bit suspicious. I'm going to close and reopen to poke the CI.

MichalStrehovsky
MichalStrehovsky approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the CI is green! Thank you!

@MichalStrehovsky MichalStrehovsky mentioned this pull request Oct 4, 2022
Merged
@MichalStrehovsky
Copy link
Member

CI is not triggering - this is blocked on #76057 (comment).

Cc @radical

Marking no merge so that nobody thinks it's green.

@MichalStrehovsky MichalStrehovsky added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Oct 4, 2022
@MichalStrehovsky MichalStrehovsky removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Oct 5, 2022
@filipnavara
Copy link
Member Author

I think I know what causes the failure, will check it in the morning.

@filipnavara
Copy link
Member Author

This is blocked on ingesting newer SDK that has dotnet/installer#14464 (7.0) or dotnet/installer#14443 (8.0).

@filipnavara
Copy link
Member Author

The SDK has been updated, so I rebased the PR.

@filipnavara
Copy link
Member Author

...and the CI passed successfully this time.

@filipnavara filipnavara requested a review from VSadov December 11, 2022 18:46
@ghost
Copy link

ghost commented Dec 11, 2022

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: filipnavara
Assignees: -
Labels:

community-contribution, area-NativeAOT-coreclr
Milestone: -

@MichalStrehovsky MichalStrehovsky merged commit 7e10f81 into dotnet:main Dec 12, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jan 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MichalStrehovsky MichalStrehovsky MichalStrehovsky approved these changes

@VSadov VSadov Awaiting requested review from VSadov

Assignees
No one assigned
Labels
area-NativeAOT-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipnavara @MichalStrehovsky